gabotechs commented on code in PR #25570:
URL: https://github.com/apache/datafusion/pull/25570#discussion_r4180974172
##########
benchmarks/src/statistics.rs:
##########
@@ -184,7 +184,10 @@ impl RunOpt {
let logical_plan = state.optimize(&logical_plan)?;
let physical_plan = state.create_physical_plan(&logical_plan).await?;
- let statistics = capture_statistics(physical_plan.as_ref())?;
+ let statistics = capture_statistics(
Review Comment:
The code touched here is not production code, it's just a tool for
qualifying changes to stats-related code.
Whether it uses `default_with_builtin_providers` is an implementation detail
from which users are abstracted of, so I'm hesitant to introduce a test coupled
to implementations detail that adds maintainance burden without really
providing any extra guarantees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
