kosiew commented on code in PR #25694:
URL: https://github.com/apache/datafusion/pull/25694#discussion_r4267962103
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -1204,4 +1205,45 @@ mod tests {
assert_eq!(merged.evaluate()?, ScalarValue::Int64(Some(3)));
Ok(())
}
+
+ #[test]
Review Comment:
It would be useful to add an end-to-end regression test with incomplete
column statistics, NULLs, and duplicates to verify that aggregation is
preserved and returns the correct counts. Please test COUNT(b) and
COUNT(DISTINCT b) separately, since the optimizer stops at the first unresolved
expression, and make sure the column index remains out of bounds after any
projection or remapping. This is optional since the existing unit tests already
cover both guarded accesses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
