alamb commented on PR #26228: URL: https://github.com/apache/datafusion/pull/26228#issuecomment-6169739489
Hi @dwsmith1983 -- thanks for this PR. Is this a general purpose change or something that is comet specific? It seems like maybe others would benefit if you could show a sort by build side was eliminated or something? I worry about adding a bunch of constrants to DataFusion for some specific usecase (Comet) that isn't used by other users of DataFusion I am not enough of an expert in the Join code to review this PR efficient. Perhaps @2010YOUY01 or @jayzhan211 could suggest someone who might be able to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
