dwsmith1983 commented on PR #26228: URL: https://github.com/apache/datafusion/pull/26228#issuecomment-6220914834
Thanks @2010YOUY01, that's a good point, and I agree it's a reason not to promise the order yet. To be clear, this PR doesn't make that promise: `maintains_input_order` still reports false for the build side, so a spilling hash join could emit rows in any order later. The change only makes the hash map path return build rows in the same order the array map path already does, so the result no longer depends on which map gets picked. The guarantee itself is tracked in #26235. I'll add your spilling example and @jayzhan211's idea of a config there so it gets settled before anyone picks that up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
