dwsmith1983 commented on PR #26228: URL: https://github.com/apache/datafusion/pull/26228#issuecomment-6228415964
Fair point: the tests pin the order, so in practice it's a promise. An opt-in flag sounds right to me and fits how Comet builds the join. Since `HashJoinExec` already has a builder, I'd add it next to `with_null_aware`, something like `with_preserve_build_order(true)`, rather than a separate constructor. The order tests would set it, and its doc would say a strategy that can't keep build order (spilling, for example) must not be used when it's on. It wouldn't touch `maintains_input_order`, so planning is unchanged and #26235 may not be needed. @andygrove would that work for Comet? It would set the flag on the null-aware anti join and then drop the fallback from apache/datafusion-comet#6810 after upgrading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
