findepi commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1768940239
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -195,9 +197,12 @@ impl ColumnarValue {
kernels::cast::cast_with_options(array, cast_type,
&cast_options)?,
)),
ColumnarValue::Scalar(scalar) => {
+ // TODO(@notfilippo, logical/physical): this cast in the
future should reduce to updating
+ // Scalar's `data_type` to the target `cast_type`.
Review Comment:
Why? Don't we need to transform the actual value, eg from int to string or
vice versa?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
