findepi commented on PR #12536: URL: https://github.com/apache/datafusion/pull/12536#issuecomment-2364175838
Brief code-level documentation -- what this new Scalar is, what it is not, what are the constraints and what's the goal of this evolution is a must for this. I would like to review again once this is added, so that I understand better what we're trying to accomplish. The referenced issue https://github.com/apache/datafusion/issues/11513 is a good record of all the discussions, but it's not clear which comments are opinions that were later refined and which are normative. Thanks for the patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org