findepi commented on code in PR #12536: URL: https://github.com/apache/datafusion/pull/12536#discussion_r1769585269
########## datafusion/expr-common/src/scalar.rs: ########## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::{ + array::{Array, ArrayRef}, + datatypes::DataType, +}; +use datafusion_common::{exec_err, DataFusionError, Result, ScalarValue}; + +#[derive(Clone, Debug)] +pub struct Scalar { + value: ScalarValue, + data_type: DataType, +} + +impl From<ScalarValue> for Scalar { + fn from(value: ScalarValue) -> Self { + Self { + data_type: value.data_type(), + value, Review Comment: > before committing on some documentation prose. that's a good point and actually, i have hard time with long documentation prose -- i am maybe a slow reader. what i am looking for is exactly what you need -- to gauge opinions you need to understand what the code says today, but also what (today) it is supposed to say tomorrow > As I understood the idea, eventually the DataType of the scalar will be different than the underlying representation @alamb , on the face value it seems to be opposite to what i understood from @notfilippo 's https://github.com/apache/datafusion/pull/12536#discussion_r1769524231. I don't have strong opinion yet what scalar should or should not be, but would be great to understand the desired end state. Can you please help me with that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
