notfilippo commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1769525452
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
The next step is to slowly remove variants of `ScalarValue` while still
accounting for them via `data_type` (which in my opinion is the least intrusive
change to support this effort). After we are satisfied with the variants that
remain we reconsider the logic in expressions and operators in order to support
what @jayzhan211 in proposing:
> I think we could have LogicalType without any Arrow's DataType contained
in it in the future
by sourcing the `data_type` directly from the execution schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
