jonahgao commented on PR #12608: URL: https://github.com/apache/datafusion/pull/12608#issuecomment-2372763476
I think this is the right way; DuckDB has a [RemoveDuplicateGroups](https://github.com/duckdb/duckdb/blob/12e9777cf6283f44710b2610ba3d3735a1208751/src/include/duckdb/optimizer/remove_duplicate_groups.hpp#L20C7-L20C28) that does the same thing. There might be a minor issue with volatile expressions, such as `group by random(), random()`, but I think we can disregard it for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
