eejbyfeldt commented on code in PR #12608:
URL: https://github.com/apache/datafusion/pull/12608#discussion_r1774864320
##########
datafusion/sql/src/planner.rs:
##########
@@ -197,9 +197,9 @@ impl PlannerContext {
/// extends the FROM schema, returning the existing one, if any
pub fn extend_outer_from_schema(&mut self, schema: &DFSchemaRef) ->
Result<()> {
- self.outer_from_schema = match self.outer_from_schema.as_ref() {
- Some(from_schema) => Some(Arc::new(from_schema.join(schema)?)),
- None => Some(Arc::clone(schema)),
+ match self.outer_from_schema.as_mut() {
+ Some(from_schema) => Arc::make_mut(from_schema).merge(schema),
+ None => self.outer_from_schema = Some(Arc::clone(schema)),
Review Comment:
@aalexandrov Can you help verify that this is correct?
I am not fully following your comment here:
https://github.com/apache/datafusion/pull/11456#discussion_r1677146980 At least
in the current code merge will still have both values for `j1_id` since they
will have different qualifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
