eejbyfeldt commented on code in PR #12608:
URL: https://github.com/apache/datafusion/pull/12608#discussion_r1775168912
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -3337,52 +3337,6 @@ mod tests {
Ok(())
}
- // Table 't1' self join
- // Supplementary test of issue:
https://github.com/apache/datafusion/issues/7790
Review Comment:
Should have explained that more in the description. Before it tests that
calling `with_column` after a self join without alias will fail in a certain
way. After this change it will fail already at the self join. So there is no
way to make it test what it testsed before and I belive the self join already
has test coverage elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
