comphead commented on code in PR #12608:
URL: https://github.com/apache/datafusion/pull/12608#discussion_r1775609041
##########
datafusion/expr/src/utils.rs:
##########
@@ -260,7 +252,11 @@ pub fn grouping_set_to_exprlist(group_expr: &[Expr]) ->
Result<Vec<&Expr>> {
}
Ok(grouping_set.distinct_expr())
} else {
- Ok(group_expr.iter().collect())
+ Ok(group_expr
+ .iter()
Review Comment:
wondering if can get rid of double collection iteration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
