alamb commented on code in PR #12308:
URL: https://github.com/apache/datafusion/pull/12308#discussion_r1777112205
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -150,21 +150,22 @@ impl ExprSchemable for Expr {
.collect::<Result<Vec<_>>>()?;
// verify that function is invoked with correct number and
type of arguments as defined in `TypeSignature`
- data_types_with_scalar_udf(&arg_data_types,
func).map_err(|err| {
- plan_datafusion_err!(
- "{} {}",
- err,
- utils::generate_signature_error_msg(
- func.name(),
- func.signature().clone(),
- &arg_data_types,
+ let new_data_types =
data_types_with_scalar_udf(&arg_data_types, func)
Review Comment:
I defer to @jayzhan211 -- if he is good to merge this PR, let's get the
conflicts resolved and merge it in.
If there is additional work we know is needed / could be cleaned up, let's
try and file them as tickets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
