findepi commented on PR #12864: URL: https://github.com/apache/datafusion/pull/12864#issuecomment-2431720968
I am not convinced that that code we eventually **should have** will be natural evolution of the code here, so it's hard for me to judge whether this is a step in the right direction. The problem is with how table-being-created's schema is passed via a "global variable" to **some** VALUES being planned, without checking whether those values are direct input to the table being created. They may or may not be. How should this be solved? I think this is a question to you @alamb more than me. But I can try to guess. For example, when planning CREATE TABLE we could check whether it's input is VALUES and bypass generic `sql_values_to_plan` in such case, calling a new function with this new functionality. What are your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
