findepi commented on code in PR #12864:
URL: https://github.com/apache/datafusion/pull/12864#discussion_r1812473251
##########
datafusion/sql/src/values.rs:
##########
@@ -31,16 +33,21 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
rows,
} = values;
- // Values should not be based on any other schema
- let schema = DFSchema::empty();
+ let empty_schema = Arc::new(DFSchema::empty());
let values = rows
.into_iter()
.map(|row| {
row.into_iter()
- .map(|v| self.sql_to_expr(v, &schema, planner_context))
+ .map(|v| self.sql_to_expr(v, &empty_schema,
planner_context))
.collect::<Result<Vec<_>>>()
})
.collect::<Result<Vec<_>>>()?;
- LogicalPlanBuilder::values(values)?.build()
+
+ let schema = planner_context.table_schema().unwrap_or(empty_schema);
+ if schema.fields().is_empty() {
+ LogicalPlanBuilder::values_with_schema(values, None)?.build()
+ } else {
+ LogicalPlanBuilder::values_with_schema(values,
Some(&schema))?.build()
Review Comment:
This remains correct only for VALUES that are **direct** input to CREATE
TABLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
