alamb commented on PR #13086: URL: https://github.com/apache/datafusion/pull/13086#issuecomment-2436115297
> The github action clippy test detects issues in datafusion-examples, but I'm unable to reproduce that locally. > > I'm fixing those issues based on the action result, I'm not sure what I need to do to generate the failures locally going forward. I normally look at the output to see what actually got run https://github.com/apache/datafusion/actions/runs/11492701486/job/31987475872 So in this case the actual command appears to be: ```shell cargo clippy --all-targets --workspace --features avro,pyarrow -- -D warnings ``` When I checked out https://github.com/apache/datafusion/pull/13086/commits/e9dfd8d64007eee89f8d58ff7071058d040f2b7a locally and ran that command things failed the same as they did on CI: ```shell ... Checking datafusion-examples v42.1.0 (/Users/andrewlamb/Software/datafusion/datafusion-examples) error: consider bringing this path into scope with the `use` keyword --> datafusion-examples/examples/flight/flight_server.rs:108:31 | 108 | let options = datafusion::arrow::ipc::writer::IpcWriteOptions::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absolute_paths = note: `-D clippy::absolute-paths` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::absolute_paths)]` ... ``` Though I did have to run `rustup update` to get the latest rust version (1.82.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
