findepi commented on code in PR #13086:
URL: https://github.com/apache/datafusion/pull/13086#discussion_r1816223116
##########
Cargo.toml:
##########
@@ -166,6 +166,8 @@ rpath = false
[workspace.lints.clippy]
# Detects large stack-allocated futures that may cause stack overflow crashes
(see threshold in clippy.toml)
large_futures = "warn"
+# Detects use of absolute paths rather than import via use statements
+absolute_paths = "warn"
Review Comment:
```suggestion
# Detects use of long absolute paths rather than import via use statements
absolute_paths = "warn"
```
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -652,8 +655,8 @@ fn partial_cmp_map(m1: &Arc<MapArray>, m2: &Arc<MapArray>)
-> Option<Ordering> {
let arr1 = m1.entries().column(col_index);
let arr2 = m2.entries().column(col_index);
- let lt_res = arrow::compute::kernels::cmp::lt(arr1, arr2).ok()?;
- let eq_res = arrow::compute::kernels::cmp::eq(arr1, arr2).ok()?;
+ let lt_res = lt(arr1, arr2).ok()?;
+ let eq_res = eq(arr1, arr2).ok()?;
Review Comment:
I actually wouldn't mind (and perhaps would even prefer) to keep this
particular piece of code as it was.
The bare `lt` isn't as self-explanatory.
Can we somehow exempt arrow compute kernels from the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
