findepi commented on PR #13086: URL: https://github.com/apache/datafusion/pull/13086#issuecomment-2437200055
> partially addresses #11317. I think this is actually a bit different. That issue says "if we already have `use foo::bar` in the file, use `bar` without qualifying it with `foo::`". I don't see any drawbacks of this yet. Clippy's `absolute_paths` meaning is different, independent of existing `use` statements. As visible in https://github.com/apache/datafusion/pull/13086#discussion_r1816228159, it's not drawbacks-free yet It seems there is no Clippy check doing _exactly_ what we want. https://github.com/rust-lang/rust-clippy/issues/4707 was rejected because rustc can do this without clippy. @dhegberg can you please experiment with turning rustc's `unused_qualifications` into an error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
