viirya commented on PR #1063: URL: https://github.com/apache/datafusion-comet/pull/1063#issuecomment-2462636757
Basically Spark tests are running with on-heap config, except for tests that particularly for off-heap test. I'm not sure if enabling off-heap for all Spark tests can pass them all. If it works, let's do it. If not, I plan to keep and rename current CometShuffleMemoryAllocator to a test-only class CometTestShuffleMemoryAllocator. Once it runs Spark tests, Comet can use CometTestShuffleMemoryAllocator to run Spark tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
