viirya commented on PR #1063: URL: https://github.com/apache/datafusion-comet/pull/1063#issuecomment-2463673050
> One other issue. I tested with `spark.memory.offHeap.enabled=false` and the shuffle did not fall back to Spark but failed at runtime. Yes. If using on-heap config, CometShuffleMemoryAllocator will throw runtime error. The test only CometTestShuffleMemoryAllocator is only used in Spark/Comet tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
