viirya commented on PR #1063: URL: https://github.com/apache/datafusion-comet/pull/1063#issuecomment-2464884026
> > Yes. If using on-heap config, CometShuffleMemoryAllocator will throw runtime error, i.e., you need to use off-heap config in Spark. > > Right, so if the user is using on-heap, we should not use Comet shuffle and should fall back to Spark. We probably just need to update `isCometShuffleEnabled` to check if off-heap is being used. Oh, I see. That sounds good. I will update it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
