viirya commented on PR #1063: URL: https://github.com/apache/datafusion-comet/pull/1063#issuecomment-2464942404
> > Hmm, I just ran TPC-H with this PR on Spark 3.4 using datafusion-comet script without any error. > > These are the settings that I am using. I am running in k8s. > > ```shell > $SPARK_HOME/bin/spark-submit \ > --master $SPARK_MASTER \ > --conf spark.eventLog.enabled=false \ > --conf spark.plugins=org.apache.spark.CometPlugin \ > --conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \ > --conf spark.driver.memory=8G \ > --conf spark.memory.offHeap.enabled=true \ > --conf spark.memory.offHeap.size=12g \ > --conf spark.executor.instances=4 \ > --conf spark.executor.memory=30719m \ > --conf spark.executor.cores=6 \ > --conf spark.comet.memory.overhead.factor=0.04 \ > --conf spark.comet.exec.enabled=true \ > --conf spark.comet.exec.shuffle.enabled=true \ > --conf spark.comet.exec.shuffle.mode=jvm \ > ``` This is what I used to run: ``` $SPARK_HOME/bin/spark-submit \ --master "local[*]" \ --jars $COMET_JAR \ --conf spark.driver.extraClassPath=$COMET_JAR \ --conf spark.executor.extraClassPath=$COMET_JAR \ --conf spark.plugins=org.apache.spark.CometPlugin --conf spark.driver.memory=8G --conf spark.executor.memory=10G --conf spark.memory.offHeap.enabled=true --conf spark.memory.offHeap.size=16G \ --conf spark.comet.enabled=true \ --conf spark.comet.exec.enabled=true \ --conf spark.comet.cast.allowIncompatible=true \ --conf spark.comet.exec.shuffle.enabled=true \ --conf spark.comet.exec.shuffle.mode=jvm \ --conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \ --benchmark tpch ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org