peter-toth commented on PR #13177:
URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2464532242
> Has anyone verified that this change fixes the issue described on ?
>
> #9373
Actually, this is a good question. I've just run this PR locally on the
attached example and I got stack overflow. The root cause is not the `TreeNode`
APIs but SQL to logical plan conversion:
```
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason =
EXC_BAD_ACCESS (code=2, address=0x16f607280)
frame #0: 0x0000000100b246d4
datafusion-cli`datafusion_sql::set_expr::_$LT$impl$u20$datafusion_sql..planner..SqlToRel$LT$S$GT$$GT$::set_expr_to_plan::h807844852e1e805e(self=0x0000000000000000,
set_expr=<unavailable>, planner_context=0x0000000000000000) at set_expr.rs:24
21 use sqlparser::ast::{SetExpr, SetOperator, SetQuantifier};
22
23 impl<'a, S: ContextProvider> SqlToRel<'a, S> {
-> 24 pub(super) fn set_expr_to_plan(
25 &self,
26 set_expr: SetExpr,
27 planner_context: &mut PlannerContext,
Target 0: (datafusion-cli) stopped.
(lldb) thread backtrace
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason =
EXC_BAD_ACCESS (code=2, address=0x16f607280)
* frame #0: 0x0000000100b246d4
datafusion-cli`datafusion_sql::set_expr::_$LT$impl$u20$datafusion_sql..planner..SqlToRel$LT$S$GT$$GT$::set_expr_to_plan::h807844852e1e805e(self=0x0000000000000000,
set_expr=<unavailable>, planner_context=0x0000000000000000) at set_expr.rs:24
frame #1: 0x0000000100b24a98
datafusion-cli`datafusion_sql::set_expr::_$LT$impl$u20$datafusion_sql..planner..SqlToRel$LT$S$GT$$GT$::set_expr_to_plan::h807844852e1e805e(self=0x000000016fd8eef8,
set_expr=SetExpr @ 0x000000016f60fc68, planner_context=0x000000016fd5ec10) at
set_expr.rs:38:33
frame #2: 0x0000000100b24a98
datafusion-cli`datafusion_sql::set_expr::_$LT$impl$u20$datafusion_sql..planner..SqlToRel$LT$S$GT$$GT$::set_expr_to_plan::h807844852e1e805e(self=0x000000016fd8eef8,
set_expr=SetExpr @ 0x000000016f613a28, planner_context=0x000000016fd5ec10) at
set_expr.rs:38:33
frame #3: 0x0000000100b24a98
datafusion-cli`datafusion_sql::set_expr::_$LT$impl$u20$datafusion_sql..planner..SqlToRel$LT$S$GT$$GT$::set_expr_to_plan::h807844852e1e805e(self=0x000000016fd8eef8,
set_expr=SetExpr @ 0x000000016f6177e8, planner_context=0x000000016fd5ec10) at
set_expr.rs:38:33
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
