alamb commented on PR #13177: URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2465457730
> > I worry it will cause some sort of hard to diagnose issue that appears only under load / memory pressure / etc > The fact that Rust compiler uses stacker doesn't alleviate your concerns? I mean, it might have been dormant for some time but as long as the compiler needs it, it seems safe to use it. I did not realize it was used by the rust compiler. I just did some research and verified it is indeed used that way: https://github.com/rust-lang/rust/blob/209799f3b910c64c8bd5001c0a8a55e03e7c2614/compiler/rustc_data_structures/src/stack.rs#L21 https://github.com/search?q=repo%3Arust-lang/rust%20ensure_sufficient_stack&type=code Based on htat new information I think stacker seems like a reasonable way to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
