andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1835729939
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+
+ test("array_append") {
Review Comment:
It would be good to also have a test where the first argument to
`array_append` is null, but where the argument is not a literal null but an
expression that evaluates to null. I am not sure how easy it is to add that
test until we have support for reading arrays from Parquet (which is coming
soon) so I am fine if we want to handle this as a separate issue. It does look
like DataFusion's `array_append` does not support null as the first argument,
but Spark does. Maybe we could improve DataFusion's implementation to return
null if the first argument is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
