NoeB commented on PR #1072: URL: https://github.com/apache/datafusion-comet/pull/1072#issuecomment-2469942871
Because array_append has been added in Spark 3.4 I had to rewrite the match statement in QueryPlanSerde because it would not compile with spark 3.3 the same thing applies to the test which I rewrote to spark.sql because the test would also not compile with spark3.3. Let me know if the approach is ok or if you have a different option in mind. I think a lot of the array functions have been added in spark 3.4 and spark3.5 so a lot more cases like this will exist in the future. Regarding the Spark 4.0 failures I could not yet check them because the tests do not seem to start on my machine with spark 4.0. I am working to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
