andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1835886113
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2313,4 +2313,22 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+
+ test("array_append") {
Review Comment:
Interesting. Let's handle this in Comet rather than modify DataFusion. One
option is to fork the `array_append` code and modify it. Another option would
be to translate `array_append(a, b)` into something like `CASE WHEN a IS NULL
THEN null ELSE array_append(a, b) END`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
