andygrove commented on code in PR #1072:
URL: https://github.com/apache/datafusion-comet/pull/1072#discussion_r1837147575
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -691,6 +693,34 @@ impl PhysicalPlanner {
expr.ordinal as usize,
)))
}
+ ExprStruct::ArrayAppend(expr) => {
+ let left =
+ self.create_expr(expr.left.as_ref().unwrap(),
Arc::clone(&input_schema))?;
+ let right =
+ self.create_expr(expr.right.as_ref().unwrap(),
Arc::clone(&input_schema))?;
+ let return_type = left.data_type(&input_schema)?;
+ let args = vec![Arc::clone(&left), right];
+ let datafusion_array_append =
+ Arc::new(ScalarUDF::new_from_impl(ArrayAppend::new()));
+ let array_append_expr: Arc<dyn PhysicalExpr> =
Arc::new(ScalarFunctionExpr::new(
+ "array_append",
+ datafusion_array_append,
+ args,
+ return_type,
+ ));
+
+ let is_null_expr: Arc<dyn PhysicalExpr> =
Arc::new(IsNullExpr::new(left));
+ let null_literal_expr: Arc<dyn PhysicalExpr> =
+ Arc::new(Literal::new(ScalarValue::Null));
+
+ let case_expr = CaseExpr::try_new(
+ None,
+ vec![(is_null_expr, null_literal_expr)],
+ Some(array_append_expr),
+ )
+ .unwrap();
Review Comment:
can we use `?` rather than `unwrap` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
