andygrove commented on code in PR #1108:
URL: https://github.com/apache/datafusion-comet/pull/1108#discussion_r1851281619
##########
native/core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -1091,6 +1103,8 @@ async fn external_shuffle(
partitioning: Partitioning,
metrics: ShuffleRepartitionerMetrics,
context: Arc<TaskContext>,
+ read_time: Time,
+ scan_time: Option<Time>,
Review Comment:
Just in case the child node of ShuffleWriterExec is not a ScanExec (I recall
seeing cases where there is an intermediate CopyExec). In that case we could
perhaps recurse down to find the ScanExec. CopyExec is another exec that we do
not currently capture metrics for
(https://github.com/apache/datafusion-comet/issues/935).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
