parthchandra commented on code in PR #1108:
URL: https://github.com/apache/datafusion-comet/pull/1108#discussion_r1852602573
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -480,7 +483,14 @@ class CometShuffleWriteProcessor(
"output_rows" ->
metrics(SQLShuffleWriteMetricsReporter.SHUFFLE_RECORDS_WRITTEN),
"data_size" -> metrics("dataSize"),
"elapsed_compute" ->
metrics(SQLShuffleWriteMetricsReporter.SHUFFLE_WRITE_TIME))
- val nativeMetrics = CometMetricNode(nativeSQLMetrics)
+
+ val nativeMetrics = if (metrics.contains("jvm_fetch_time")) {
Review Comment:
I don't know why, but data_size is also repeated between metrics and
nativeMetrics yet handled differently. Not super important though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
