andygrove commented on code in PR #1108:
URL: https://github.com/apache/datafusion-comet/pull/1108#discussion_r1852803589
##########
native/core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -1104,13 +1108,23 @@ async fn external_shuffle(
context.session_config().batch_size(),
);
- while let Some(batch) = input.next().await {
- // Block on the repartitioner to insert the batch and shuffle the rows
- // into the corresponding partition buffer.
- // Otherwise, pull the next batch from the input stream might
overwrite the
- // current batch in the repartitioner.
- block_on(repartitioner.insert_batch(batch?))?;
+ loop {
+ let mut timer = jvm_fetch_time.timer();
+ let b = input.next().await;
Review Comment:
yes, and in the case of ShuffleWriterExec, we know the input is always a
ScanExec that is reading batches from the JVM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
