andygrove commented on PR #1111: URL: https://github.com/apache/datafusion-comet/pull/1111#issuecomment-2494092069
@viirya @parthchandra @mbutrovich This is still WIP but let me know what you think of the overall approach here if you have time. Current status is that we now log the metrics that we are dropping. Here are two examples from TPC-H q3. We wrap an aggregate in a projection causing: ``` Dropping the AggregateExec elapsed_compute time of 1820330 for plan ProjectionExec (#624) ``` The input to a SortExec is a ScanExec to fetch the input batches from the JVM, and we drop those metrics: ``` Dropping the ScanExec elapsed_compute time of 1151562087 for plan SortExec (#0) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
