mbutrovich commented on PR #1111: URL: https://github.com/apache/datafusion-comet/pull/1111#issuecomment-2494641304
My initial thoughts: - Approach makes sense. This is good infrastructure to have for managing when Spark plans and native plans diverge in node count and structure. - I am worried about more logic in `update_comet_metric` as discussed in #1024. However, we also shouldn't lose metrics. This may be motivation to revisit some of the potential solutions in #1024. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
