andygrove commented on code in PR #1111:
URL: https://github.com/apache/datafusion-comet/pull/1111#discussion_r1854181070
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -950,17 +962,29 @@ impl PhysicalPlanner {
//
// Note that `result_exprs` should only be set for final
aggregation on the
// Spark side.
- Arc::new(ProjectionExec::try_new(result_exprs?,
aggregate)?)
- };
-
- Ok((scans, exec))
+ let projection =
+ Arc::new(ProjectionExec::try_new(result_exprs?,
aggregate.clone())?);
+ Ok((
+ scans,
+ Arc::new(SparkPlan::new_with_additional(
+ spark_plan.plan_id,
+ projection,
+ vec![child],
+ vec![aggregate],
+ )),
Review Comment:
This is an example where we are currently dropping the aggregate metrics and
just capturing the project metrics
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -950,17 +962,29 @@ impl PhysicalPlanner {
//
// Note that `result_exprs` should only be set for final
aggregation on the
// Spark side.
- Arc::new(ProjectionExec::try_new(result_exprs?,
aggregate)?)
- };
-
- Ok((scans, exec))
+ let projection =
+ Arc::new(ProjectionExec::try_new(result_exprs?,
aggregate.clone())?);
+ Ok((
+ scans,
+ Arc::new(SparkPlan::new_with_additional(
+ spark_plan.plan_id,
+ projection,
+ vec![child],
+ vec![aggregate],
+ )),
Review Comment:
This is an example where we are currently dropping the aggregate metrics and
just capturing the projection metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
