jayzhan211 commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1890996124
##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|arg_types| {
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
+ #[allow(deprecated)]
Review Comment:
I think deprecate `return_type` and switch to `return_type_from_exprs` force
the user to have `args` and `schema` which is not ideal, since they are
optional parameter for certain function only. Without a doubt, they might pass
the empty `vec![]` and empty schema ... which doesn't make sense, why not wrap
it with `Optional`. That is why `return_type_with_args` with optional parameter
is a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
