findepi commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1890695092
##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
.into_iter()
.map(|arg_types| {
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
+ #[allow(deprecated)]
Review Comment:
> The optionality is the same as the current status where you can use
`return_type` for simple case or `return_type_from_exprs` for advanced case.
Correct. And `return_type_with_args` would not solve this dichotomy problem.
It would only make it less clear and harder to implement correctly.
Since we're really solving information_schema problem now, we should think
what could be the best solution for information_schema. **For example**, we
could rename `return_type` or replace with `get_possible_return_types`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
