goldmedal commented on PR #1598: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1598#issuecomment-2562982937
Hi @ayman-sigma, @iffyio, I'm concerned about this change. Is `SELECT * FROM foo-123.bar` valid SQL or a real use case for BigQuery? 🤔 Based on the [BigQuery documentation](https://cloud.google.com/bigquery/docs/datasets#dataset-naming), dataset names cannot contain spaces or special characters such as `-`, `&`, `@`, or `%`. This PR modifies the tokenizer for numbers, which breaks SQL (It parsed to a wrong result, see #1619 ) like: ```sql SELECT 0. AS c1 ``` This syntax is valid in BigQuery. Additionally, I'm concerned about unquoted hyphenated identifiers, made in #1109 by @jmhain I can't execute the following SQL on my BigQuery project: ```sql SELECT * FROM foo-bar ``` Generally, `-` is not a valid character for identifiers. The table name should be quoted, like this: ```sql SELECT * FROM `foo-bar` ``` Is there any documentation that explicitly covers this 🤔 ? The only relevant information I found was about [unquoted identifiers](https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#unquoted_identifiers): > Must begin with a letter or an underscore (_) character. > Subsequent characters can be letters, numbers, or underscores (_). also c.c. @alamb who reviewed #1109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
