goldmedal commented on PR #1598: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1598#issuecomment-2563260997
> I'm not sure about the table name, but I know for sure that project name allows unquoted hyphenated identifier for BigQuery. > Indeed, I have confirmed it: the project name is allowed to be an unquoted hyphenated identifier. 👍  > I believe the original PR from @jmhain was scoped to BigQuery, so we should be fine there. We just need to fix the tokenizer again for your case. The tokenizer change in this PR allow parsing `foo-123.bar` as `[Word('"foo"), Minus, Number("123"), Period, Word("bar")]` instead of `[Word("foo"), Minus, Number("123."), Word("bar")]`. I believe the former is more correct than the latter. You can scope that change to BigQuery, but I prefer that we fix it to allow the `1.` and `1.e5`, ... cases. > I see. I think it's a BigQuery-specific behavior, not a common rule for others. I will add a method `Dialect::support_unquoted_hyphenated_identifiers` to scope it. Thanks for your explanation. 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
