ayman-sigma commented on PR #1598: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1598#issuecomment-2563112154
> Hi @ayman-sigma, @iffyio, > > I'm concerned about this change. Is `SELECT * FROM foo-123.bar` valid SQL or a real use case for BigQuery? 🤔 > > Based on the [BigQuery documentation](https://cloud.google.com/bigquery/docs/datasets#dataset-naming), dataset names cannot contain spaces or special characters such as `-`, `&`, `@`, or `%`. I think my example here was bad. I meant to write something like `SELECT * FROM foo-123.mydataset.mytable` which is a valid table syntax according to the docs you mentioned above. > This PR modifies the tokenizer for numbers, which breaks SQL (It parsed to a wrong result, see #1619 ) like: > > ```sql > SELECT 0. AS c1 > ``` > > This syntax is valid in BigQuery. Sorry about breaking that case. I'm actually surprised we don't have a test case for that. I think it easy to fix the case of `SELECT 1. AS c1`, but it will be tricky to handle `SELECT 1.e5` for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
