alamb commented on code in PR #14255:
URL: https://github.com/apache/datafusion/pull/14255#discussion_r1927794719
##########
datafusion/common/src/column.rs:
##########
@@ -71,7 +71,11 @@ impl Column {
}
}
- fn from_idents(idents: &mut Vec<String>) -> Option<Self> {
+ /// Create a Column from multiple normalized identifiers
+ ///
+ /// For example, `foo.bar` would be represented as a two element vector
+ /// `["foo", "bar"]`
+ pub fn from_idents(mut idents: Vec<String>) -> Option<Self> {
Review Comment:
i made this public and cleaned up the signature so I could reuse it when
dealing with the changes to `USING` planning
However I am not sure what a `USING(foo.bar)` would actually mean 🤔 Maybe
when joining across multiple schemas?
I would be interested in hearing the reviewers opinions on if I should
should revert this change and return a planner error if it got a multi-part
ObjectName in a `USING` clause
Perhaps @jonahgao has some opinions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
