Re: [PR] chore(deps): Update sqlparser to 0.54.0 @alamb [datafusion]

[via GitHub]

jonahgao commented on code in PR #14255:
URL: https://github.com/apache/datafusion/pull/14255#discussion_r1928024793


##########
datafusion/common/src/column.rs:
##########
@@ -71,7 +71,11 @@ impl Column {
         }
     }
 
-    fn from_idents(idents: &mut Vec<String>) -> Option<Self> {
+    /// Create a Column from multiple normalized identifiers
+    ///
+    /// For example, `foo.bar` would be represented as a two element vector
+    /// `["foo", "bar"]`
+    pub fn from_idents(mut idents: Vec<String>) -> Option<Self> {

Review Comment:
   This syntax is from Snowflake. I tested it on Snowflake, and 
`USING(foo.bar)` has the same effect as  `USING(bar)`.
   ![CleanShot 2025-01-24 at 10 57 
25@2x](https://github.com/user-attachments/assets/95da4ee6-8f6c-49c9-960c-78ca246947b8)
   
   DataFusion gave a different result; it did not deduplicate the using column.
   ```sh
   > with t1 as (select 1 as a),
   t2 as (select 1 as a)
   select * from t1 join t2 using(t1.a);
   +---+---+
   | a | a |
   +---+---+
   | 1 | 1 |
   +---+---+.
   ```
   Instead of giving an incorrect result, perhaps the simplest approach is to 
return an error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org