alamb commented on code in PR #14255:
URL: https://github.com/apache/datafusion/pull/14255#discussion_r1930887958
##########
datafusion/common/src/column.rs:
##########
@@ -71,7 +71,11 @@ impl Column {
}
}
- fn from_idents(idents: &mut Vec<String>) -> Option<Self> {
+ /// Create a Column from multiple normalized identifiers
+ ///
+ /// For example, `foo.bar` would be represented as a two element vector
+ /// `["foo", "bar"]`
+ fn from_idents(mut idents: Vec<String>) -> Option<Self> {
Review Comment:
Changed the signature to be easier to work with (pass the vec by ownership
rather than &mut)
##########
datafusion/common/src/column.rs:
##########
@@ -71,7 +71,11 @@ impl Column {
}
}
- fn from_idents(idents: &mut Vec<String>) -> Option<Self> {
+ /// Create a Column from multiple normalized identifiers
+ ///
+ /// For example, `foo.bar` would be represented as a two element vector
+ /// `["foo", "bar"]`
+ pub fn from_idents(mut idents: Vec<String>) -> Option<Self> {
Review Comment:
I have made such queries error now and added a test in
[250115a](https://github.com/apache/datafusion/pull/14255/commits/250115ac5c1805cf3324ba94bb613bdb5171403e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
