PokIsemaine commented on code in PR #1724:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1955494712
##########
src/ast/query.rs:
##########
@@ -2205,31 +2205,50 @@ pub enum JoinConstraint {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub struct OrderBy {
- pub exprs: Vec<OrderByExpr>,
- /// Optional: `INTERPOLATE`
- /// Supported by [ClickHouse syntax]
+pub enum OrderBy {
Review Comment:
This is worth considering, `ORDER BY ALL` supports `ASC`, `DSC`, but `FILL`
and `INTERPOLATE` are not supported in `ClickHouse`.
[ORDER BY ALL WITH FILL
playground](https://sql.clickhouse.com?query=U0VMRUNUIG51bWJlciBhcyBrZXksIDUgKiBudW1iZXIgdmFsdWUsICdvcmlnaW5hbCcgQVMgc291cmNlCkZST00gbnVtYmVycygxNikgV0hFUkUga2V5ICUgNSA9PSAwCk9SREVSIEJZIEFMTCBXSVRIIEZJTEw7&chart=eyJ0eXBlIjoibGluZSIsImNvbmZpZyI6eyJ4YXhpcyI6InllYXIiLCJ5YXhpcyI6Ijk5dGhfYXZnX3RlbXAiLCJzZXJpZXMiOiJjb3VudHJ5IiwidGl0bGUiOiJUZW1wZXJhdHVyZSBieSBjb3VudHJ5IGFuZCB5ZWFyIn19&;)
[ORDER BY ALL WITH INTERPOLATE
playground](https://sql.clickhouse.com?query=U0VMRUNUIG4sIHNvdXJjZSwgaW50ZXIgRlJPTSAoCiAgIFNFTEVDVCB0b0Zsb2F0MzIobnVtYmVyICUgMTApIEFTIG4sICdvcmlnaW5hbCcgQVMgc291cmNlLCBudW1iZXIgYXMgaW50ZXIKICAgRlJPTSBudW1iZXJzKDEwKSBXSEVSRSBudW1iZXIgJSAzID0gMQopIE9SREVSIEJZIEFMTCBXSVRIIEZJTEwgRlJPTSAwIFRPIDUuNTEgU1RFUCAwLjUgSU5URVJQT0xBVEUgKGludGVyIEFTIGludGVyICsgMSk7&chart=eyJ0eXBlIjoibGluZSIsImNvbmZpZyI6eyJ4YXhpcyI6InllYXIiLCJ5YXhpcyI6Ijk5dGhfYXZnX3RlbXAiLCJzZXJpZXMiOiJjb3VudHJ5IiwidGl0bGUiOiJUZW1wZXJhdHVyZSBieSBjb3VudHJ5IGFuZCB5ZWFyIn19&;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
