iffyio commented on code in PR #1724:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1963056561
##########
src/dialect/duckdb.rs:
##########
@@ -89,4 +89,9 @@ impl Dialect for DuckDbDialect {
fn supports_from_first_select(&self) -> bool {
true
}
+
+ // See DuckDB
<https://duckdb.org/docs/sql/query_syntax/orderby.html#order-by-all-examples>
Review Comment:
You're right, we don't run any lint for this in the project unfortunattely
so there are discrepancies in the codebase. Ideally especially for public
functions, in order for the comment to show up in the documentation `///` is
required, whereas `//` is a internal-only code comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
