iffyio commented on code in PR #1724:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1724#discussion_r1956406082
##########
src/ast/query.rs:
##########
@@ -2205,31 +2205,50 @@ pub enum JoinConstraint {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub struct OrderBy {
- pub exprs: Vec<OrderByExpr>,
- /// Optional: `INTERPOLATE`
- /// Supported by [ClickHouse syntax]
+pub enum OrderBy {
Review Comment:
I think that would be fine, in the `ALL` case where they aren't provided
then `interpolate` could be None I imagine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
