2010YOUY01 commented on code in PR #14922:
URL: https://github.com/apache/datafusion/pull/14922#discussion_r1977094812
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -377,6 +377,21 @@ impl FileFormat for ParquetFormat {
Ok(Arc::new(schema))
}
+ async fn transform_schema(&self, schema: SchemaRef) -> Result<SchemaRef> {
Review Comment:
Is this transformation rule adapted from some existing transformation?
Because there is an additional rule here: `transform_binary_to_string`, so I
made a such guess.
If so, perhaps we should extract the common logic to keep it consistent, or
at least let them reference to each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
