zhuqi-lucas commented on PR #14922: URL: https://github.com/apache/datafusion/pull/14922#issuecomment-2700908676
> Thank you for this PR and report @zhuqi-lucas > > It seems like the problem is that `VARCHAR` in SQL is treated as `Utf8` (see my comment here [#14909 (comment)](https://github.com/apache/datafusion/issues/14909#issuecomment-2700708838)) > > It seems to me like this PR is a workaround -- if we make this change SQL VARCHAR will be treated as Utf8View for create table statements with parquet but Utf8 otherwise. I think this discrepancy is why you had to change the insert cases > > I think a better approach would be to change the mapping of `VARCHAR` to `Utf8View` everywhere (change this line > > https://github.com/apache/datafusion/blob/c0d53adf8323b840d0adaa62ba868d6acd4ba886/datafusion/sql/src/planner.rs#L561 > > ) though this might be significantly more disruptive Thank you @alamb for review and explain, mapping of `VARCHAR` to `Utf8View` everywhere is really a better solution, i will try to address this idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
