zhuqi-lucas commented on code in PR #14922:
URL: https://github.com/apache/datafusion/pull/14922#discussion_r1977263162
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -377,6 +377,21 @@ impl FileFormat for ParquetFormat {
Ok(Arc::new(schema))
}
+ async fn transform_schema(&self, schema: SchemaRef) -> Result<SchemaRef> {
Review Comment:
Right, we call it at the end of infer_shema, but it's not limited to
infer_shema:
```rust
let schema = if self.binary_as_string() {
transform_binary_to_string(&schema)
} else {
schema
};
let schema = if self.force_view_types() {
transform_schema_to_view(&schema)
} else {
schema
};
```
I will try to extract the common logic to make it consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
