zhuqi-lucas commented on code in PR #14922: URL: https://github.com/apache/datafusion/pull/14922#discussion_r1983002556
########## datafusion/sqllogictest/test_files/aggregate_skip_partial.slt: ########## @@ -289,14 +289,11 @@ SELECT c2, approx_median(c5), approx_median(c11) FROM aggregate_test_100 GROUP B 5 593204320 0.5156586 # Test approx_distinct for varchar / int -query III +query error SELECT c2, approx_distinct(c1), approx_distinct(c5) FROM aggregate_test_100 GROUP BY c2 ORDER BY c2; ---- -1 5 22 -2 5 22 -3 5 19 -4 5 23 -5 5 14 +DataFusion error: This feature is not implemented: Support for 'approx_distinct' for data type Utf8View is not implemented Review Comment: approx_distinct seems not support Utf8View We may need to file a ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
